Bläddra i källkod

wipfix(i18n): make sure to check for string

Likely introdued in https://github.com/PrivateBin/PrivateBin/pull/1730
rugk 5 månader sedan
förälder
incheckning
38baa8edbe
1 ändrade filer med 5 tillägg och 3 borttagningar
  1. 5 3
      js/privatebin.js

+ 5 - 3
js/privatebin.js

@@ -943,18 +943,20 @@ window.PrivateBin = (function () {
         };
         };
 
 
         /**
         /**
-         * Check if string contains valid HTML code
+         * Check if string contains valid HTML code.
+         * 
+         * If it is no string at all, this always returns false for compatibility.
          *
          *
          * @name I18n.isStringContainsHtml
          * @name I18n.isStringContainsHtml
          * @function
          * @function
          * @private
          * @private
-         * @param {string} messageId
+         * @param {string|object} messageId
          * @returns {boolean}
          * @returns {boolean}
          */
          */
         function isStringContainsHtml(messageId) {
         function isStringContainsHtml(messageId) {
             // message IDs are allowed to contain anchors, spans, keyboard and emphasis tags
             // message IDs are allowed to contain anchors, spans, keyboard and emphasis tags
             // we can recognize all of them by only checking for anchors and keyboard tags
             // we can recognize all of them by only checking for anchors and keyboard tags
-            return messageId.indexOf('<a') !== -1 || messageId.indexOf('<kbd') !== -1;
+            return typeof messageId === 'string' && (messageId.indexOf('<a') !== -1 || messageId.indexOf('<kbd') !== -1);
         }
         }
 
 
         return me;
         return me;