Просмотр исходного кода

Use a string statusCode in the YourlsProxy test

YOURLS returns the status code as a string (see #1844); mirror that in
the regression test so it stays correct if the comparison ever changes.
TowyTowy 2 недель назад
Родитель
Сommit
bb8b77d714
1 измененных файлов с 3 добавлено и 2 удалено
  1. 3 2
      tst/YourlsProxyTest.php

+ 3 - 2
tst/YourlsProxyTest.php

@@ -139,8 +139,9 @@ class YourlsProxyTest extends TestCase
     {
     {
         // YOURLS may reply with statusCode 200 but without a shorturl field;
         // YOURLS may reply with statusCode 200 but without a shorturl field;
         // this must be handled gracefully as an error instead of raising a
         // this must be handled gracefully as an error instead of raising a
-        // TypeError (the method is declared to return ?string)
-        file_put_contents($this->_mock_yourls_service, '{"statusCode":200}');
+        // TypeError (the method is declared to return ?string). YOURLS returns
+        // the status code as a string, so mirror that here.
+        file_put_contents($this->_mock_yourls_service, '{"statusCode":"200"}');
 
 
         $yourls = new YourlsProxy($this->_conf, 'https://example.com/?foo#bar');
         $yourls = new YourlsProxy($this->_conf, 'https://example.com/?foo#bar');
         $this->assertTrue($yourls->isError());
         $this->assertTrue($yourls->isError());