Explorar el Código

perf(configuration): Do not create multiple instances of Configuration

Since the configuration is loaded in the _init method, and this method
is called in the _construct, there is no reason to instanciate the
Configuration class more than once.
Jacques Bodin-Hullin hace 1 año
padre
commit
c62a3fbd2d
Se han modificado 1 ficheros con 0 adiciones y 4 borrados
  1. 0 4
      lib/Controller.php

+ 0 - 4
lib/Controller.php

@@ -190,8 +190,6 @@ class Controller
      */
     private function _setDefaultLanguage()
     {
-        $this->_conf = new Configuration;
-
         $lang = $this->_conf->getKey('languagedefault');
         I18n::setLanguageFallback($lang);
         // force default language, if language selection is disabled and a default is set
@@ -208,8 +206,6 @@ class Controller
      */
     private function _setDefaultTemplate()
     {
-        $this->_conf = new Configuration;
-
         $templates = $this->_conf->getKey('availabletemplates');
         $template  = $this->_conf->getKey('template');
         TemplateSwitcher::setAvailableTemplates($templates);