YourlsProxyTest.php 5.1 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137
  1. <?php declare(strict_types=1);
  2. use PHPUnit\Framework\TestCase;
  3. use PrivateBin\Configuration;
  4. use PrivateBin\Proxy\YourlsProxy;
  5. class YourlsProxyTest extends TestCase
  6. {
  7. private $_conf;
  8. private $_path;
  9. private $_mock_yourls_service;
  10. public function setUp(): void
  11. {
  12. /* Setup Routine */
  13. $this->_path = sys_get_temp_dir() . DIRECTORY_SEPARATOR . 'privatebin_data';
  14. if (!is_dir($this->_path)) {
  15. mkdir($this->_path);
  16. }
  17. $this->_mock_yourls_service = $this->_path . DIRECTORY_SEPARATOR . 'yourls.json';
  18. $options = parse_ini_file(CONF_SAMPLE, true);
  19. $options['main']['basepath'] = 'https://example.com/';
  20. $options['main']['urlshortener'] = 'https://example.com/shortenviayourls?link=';
  21. $options['yourls']['apiurl'] = $this->_mock_yourls_service;
  22. Helper::confBackup();
  23. Helper::createIniFile(CONF, $options);
  24. $this->_conf = new Configuration;
  25. }
  26. public function tearDown(): void
  27. {
  28. /* Tear Down Routine */
  29. unlink(CONF);
  30. Helper::confRestore();
  31. Helper::rmDir($this->_path);
  32. }
  33. public function testYourlsProxy()
  34. {
  35. // the real service answer is more complex, but we only look for the shorturl & statusCode
  36. file_put_contents($this->_mock_yourls_service, '{"shorturl":"https:\/\/example.com\/1","statusCode":200}');
  37. $yourls = new YourlsProxy($this->_conf, 'https://example.com/?foo#bar');
  38. $this->assertFalse($yourls->isError());
  39. $this->assertEquals($yourls->getUrl(), 'https://example.com/1');
  40. $yourls = new YourlsProxy($this->_conf, 'https://example.com/?@foreign.malicious.example?foo#bar');
  41. $this->assertFalse($yourls->isError());
  42. $this->assertEquals($yourls->getUrl(), 'https://example.com/1');
  43. }
  44. /**
  45. * @dataProvider providerInvalidUrl
  46. */
  47. public function testImvalidUrl($url): void
  48. {
  49. $yourls = new YourlsProxy($this->_conf, $url);
  50. $this->assertTrue($yourls->isError());
  51. $this->assertEquals($yourls->getError(), 'Invalid URL given.');
  52. }
  53. public function providerInvalidUrl(): array
  54. {
  55. return array(
  56. array(''),
  57. array(' '),
  58. array('foo'),
  59. array('https://'),
  60. array('https://example.com'), // missing path and query parameter,
  61. array('https://example.com/'), // missing query parameter
  62. array('https://example.com?paste=something'), // missing path parameter
  63. array('https://example.com@foreign.malicious.example?foo#bar'), // missing path parameter
  64. );
  65. }
  66. /**
  67. * This tests for a trick using username of an URI, see:
  68. * {@see https://cloud.google.com/blog/topics/threat-intelligence/url-obfuscation-schema-abuse/?hl=en}
  69. *
  70. * @dataProvider providerForeignUrlUsernameTrick
  71. */
  72. public function testForeignUrlUsingUsernameTrick($url): void
  73. {
  74. $yourls = new YourlsProxy($this->_conf, $url);
  75. $this->assertTrue($yourls->isError());
  76. $this->assertEquals($yourls->getError(), 'Trying to shorten a URL that isn\'t pointing at our instance.');
  77. }
  78. public function providerForeignUrlUsernameTrick(): array
  79. {
  80. return array(
  81. array('https://example.com@foreign.malicious.example/?foo#bar'),
  82. array('https://example.com/@foreign.malicious.example?foo#bar'),
  83. );
  84. }
  85. /**
  86. * @dataProvider providerForeignUrl
  87. */
  88. public function testForeignUrl($url): void
  89. {
  90. $yourls = new YourlsProxy($this->_conf, $url);
  91. $this->assertTrue($yourls->isError());
  92. $this->assertEquals($yourls->getError(), 'Trying to shorten a URL that isn\'t pointing at our instance.');
  93. }
  94. public function providerForeignUrl(): array
  95. {
  96. return array(
  97. array('ftp://example.com/?n=np'), // wrong protocol
  98. array('https://other.example.com/?foo#bar'), // wrong domain
  99. array('https://other.example.com/?q=https://example.com/?foo#bar'), // domain included inside string
  100. );
  101. }
  102. public function testYourlsError()
  103. {
  104. // when statusCode is not 200, shorturl may not have been set
  105. file_put_contents($this->_mock_yourls_service, '{"statusCode":403}');
  106. $yourls = new YourlsProxy($this->_conf, 'https://example.com/?foo#bar');
  107. $this->assertTrue($yourls->isError());
  108. $this->assertEquals($yourls->getError(), 'Proxy error: Error parsing proxy response. This can be a configuration issue, like wrong or missing config keys.');
  109. }
  110. public function testServerError()
  111. {
  112. // simulate some other server error that results in a non-JSON reply
  113. file_put_contents($this->_mock_yourls_service, '500 Internal Server Error');
  114. $yourls = new YourlsProxy($this->_conf, 'https://example.com/?foo#bar');
  115. $this->assertTrue($yourls->isError());
  116. $this->assertEquals($yourls->getError(), 'Proxy error: Error parsing proxy response. This can be a configuration issue, like wrong or missing config keys.');
  117. }
  118. }