Преглед изворни кода

snac(8): Words of caution for strip_exif configuration

Add words of caution and reasoning to the "strip_exif" configuration for
the server.json file, as these commands would be executed outside of the
sandbox - at least on OpenBSD - and both have quite a history on
security issues due to their huge attack surface and variety of
supported protocols.

After getting comfortable with the related code, I would continue using
it on a personal instance, but would reconsider enabling "strip_exif" on
shared instances with multiple users.

IMO, snac administrators should at least know of potential dangers.
Alvar Penning пре 5 месеци
родитељ
комит
110032fb48
1 измењених фајлова са 11 додато и 0 уклоњено
  1. 11 0
      doc/snac.8

+ 11 - 0
doc/snac.8

@@ -310,6 +310,17 @@ If set to true, EXIF and other metadata will be stripped from uploaded images (j
 tools to be installed. If
 .Nm snac
 cannot find or execute these tools at startup, it will refuse to run.
+.Pp
+When enabled, registered users might pass arbitrary files to
+.Nm mogrify
+or
+.Nm ffmpeg .
+These commands are being executed outside the sandbox and have a huge
+attack surface. Exploits would be run as the
+.Nm
+system user. Reconsider enabling this on
+.Nm
+instances with unknown or untrusted users.
 .It Ic mogrify_path
 Overrides the default "mogrify" command name or path. Use this if the tool is not in the system PATH or has a different name.
 .It Ic ffmpeg_path